Declan McKenna
Declan McKenna
This has been replaced by [this PR](https://github.com/SDWebImage/SDWebImage/pull/3389) which has the same functionality but excludes the lock from being used in iOS 15+ for performance reasons.
@stephencelis Can we reopen this? Using the named parameter is a work-around rather than a fix. It won't be immediately obvious to anyone other than those within this thread.
Sorry I must have skimmed this thread and missed #585 completely. Thanks for getting this merged and thanks @krzysztofpawski for taking the time to fix this 🍾
@dmitri-zganiaiko Nice find on the threshhold calculation I think @pimms has addressed it and this is ready for review again.
This is still blocked I think we need an approval from someone with write access. @stephencelis @mbrandonw are you able to help with this?
One more thing, what exactly does 1 byte of the `pixelDensityThreshold` equate to? I'm not very familiar with the ins and outs of Image diffing. i.e. What value would this...
We've tried changing the testname so you record different images based on your devices architecture. This code can be placed in a wrapper for the snapshot testing so it's always...
We're currently in the process of [modifying this screen](https://github.com/tumblr/kanvas-ios/pull/130) after apple [rejected the iOS app](https://wp.me/pbzQyC-248) based on it. This is what the new screen currently looks like for our hotfix....
~~Reopening as the crash this PR was designed to fix [still exists](https://github.com/SDWebImage/SDWebImage/issues/3273#issuecomment-1252511735).~~
> `pip3 install torch-tensorrt== -f https://github.com/pytorch/TensorRT/releases/expanded_assets/` > Leads to this error @pbamotra I've the same issue, did you find a solution for this?