Danny Burt

Results 45 comments of Danny Burt

Hey rakr! Is there any update on this?

Awesome. I created a PR: https://github.com/Dbz/kube-aliases/pull/20 I'm going to add some tests

How do you feel about `del` vs `rm` for delete? `rm` is a character less

I am not sure if we'll be permitted to add the generating aliases binary to the official oh-my-zsh repo, but we should definitely be allowed to at least add our...

I'm in no rush to merge. I'd love to get this polished before that. I'll actually work off a branch and then merge into this branch. I only created a...

I created a PR to rebase this branch on top of master: https://github.com/Dbz/kube-aliases/pull/21 It definitely needs some 👀

What do you think about removing `bin/generate-kube-aliases` from git? Seems like something to add to the `.gitignore`. I didn't want to do that without asking you first

OK, here is the PR to remove the leaky abstraction. I did a little bit of extra refactoring to combine `Generate` and `GenerateAdditional`: https://github.com/Dbz/kube-aliases/pull/26

Well, I think this is looking great. I like all of your bullets. I would add we should make the user provided aliases go into a separate file so we're...

So I realize, in order to allow folks to generate their own stuff, we do need to include a binary in git :( . I usually dislike that, so maybe...