Davis Vaughan

Results 746 comments of Davis Vaughan

If it is just about updating snapshot tests, I think the tidymodels team is going to be more than willing to update their snapshots in favor of some improvements with...

This is documented in `?strptime` under the section `Printing years` > For years 0 to 999 most OSes pad with zeros or spaces to 4 characters, and Linux outputs just...

I can't speak to the harmlessness of using `%04Y` everywhere. It _feels_ to me like that should have errored on a Mac, even though it doesn't (it "works" for me...

oldrel-4 is failing because of `timeDate: Needs R >= 3.6.0 ` which just happened on Sept 30

It was actually _two_ problems in r-devel. The PR was motivated by this one (not sure how I messed up the link before): https://stat.ethz.ch/pipermail/r-devel/2022-October/082075.html And while working on it I...

slider also fails on r-devel (CRAN pinged me about it with a request that I fix slider, but it is a lubridate issue). I was able to get r-devel installed...

I've tracked down the issue with `+ months(0:3)` and that one looks like a r-devel bug so I posted here: https://stat.ethz.ch/pipermail/r-devel/2022-October/082066.html

`expand_grid()` takes `...`, the signature isn't `.data, ...` like `mutate()`. Just want to clarify that up front. Beyond that, this is just the fact that `expand_grid()` evaluates its arguments sequentially...

In my brain it should just capture `...` with `list2()`, so yea, agreed Like, when do you really use the "sequential evaluation" feature with `expand_grid()`? I don't think I ever...

I actually think this behavior is good and correct. I think `[` is a suitably low level operation that it shouldn't apply automatic name repair because it is going to...