Davis Vaughan

icon indicating an email [email protected]

icon company @posit-dev icon location Charlotte, NC icon location Working on all things @tidyverse and @r-lib to make data analysis more fun

Results 754 comments of Davis Vaughan

Implement alternatives to the `vec_unique_*()` family

Since we figured out how to fix the dictionary is full issue in https://github.com/r-lib/vctrs/pull/1363, I'm not 100% convinced we should do this It does seem to be decently faster in...

Export `stop_unsupported()`

Although this seems to work fairly well too (at least for rcrd types which error by default on all math functions) ```r #' @export vec_math.clock_calendar

Return `NA` from `max/min.vctrs_vctr` with empty vectors

It really seems like the minimum and maximum allowed values of a specific ptype are specific to that ptype, and can often be impossible to guess using general heuristics. Maybe...

Early exit for only `TRUE` in `vec_slice()`

I'm not quite sure we'd want to optimize for this case yet. I don't love early exits like these in general because they add one more special code path that...

Quadratic memory consumption in `vec_unchop()` for `list_of` prototype

I think this is mainly due to the fact that df-assign has to proxy and restore the output container at every iteration. i.e. recursive proxy/restore would really help here https://github.com/r-lib/vctrs/issues/1107...

Error in `date_validate()`: [dplyr library - This is an internal error in the rlang package, please report it to the package authors.]

I'm seeing > ! Corrupt Date with unknown type character. It is likely that you have some kind of corrupt column in your data frame. Can you please post a...

Error in `date_validate()`: [dplyr library - This is an internal error in the rlang package, please report it to the package authors.]

I can only reproduce this with significant effort, so I think it is an error with your data generating process somehow, and not an error with rlang, vctrs, or dplyr....

Implement `use_compat()`

Decide if https://usethis.r-lib.org/reference/use_github_file.html is good enough instead ```r usethis::use_github_file("r-lib/rlang", path = "R/compat-purrr.R", save_as = "R/compat-purrr.R") ```

Need to look at the exit status as well

Here is the example from vetiver, which happened when CRAN was down: ```r ── R CMD check ───────────────────────────────────────────────────────────────── * using log directory '/home/runner/work/vetiver-r/vetiver-r/check/vetiver.Rcheck' * using R version 4.2.0 (2022-04-22) *...

Replace `panel_data` class with `tsibble`?

@jacob-long since you have said you care a lot about ensuring that `lag()` works correctly, you might also be interested in this issue https://github.com/tidyverts/tsibble/issues/55 @earowang I have a slightly optimistic...