Davis Vaughan

Results 672 comments of Davis Vaughan
trafficstars

Breaks 11 packages, but does fix the 3 packages that had S3 consistency issues, which is good news. The 11 breakages are mainly due to people doing `pivot_wider(df, id, )`,...

Maybe look for a fallback idea? Check for a single unnamed argument to see if `id_cols` is being used without being named. Throw a warning and make that work anyways...

https://github.com/tidyverse/readr/commit/e72a281f517025174ddd3aaf6feb805ec022ba5b

I'll look at these in some detail next week, thanks @mgirlich

After writing a `[` method for rsample, I firmly believe that a helper that would return `i` and `j` in a standardized format would be extremely useful. It is incredibly...

@krlmlr i spent some time working on this and came up with: https://github.com/DavisVaughan/standardize

Were you using some package that created a `"fake"` object? Or is this something you created yourself?

Developer note: This is due to this section of `list_init_empty()`: https://github.com/tidyverse/tidyr/blob/5da45d05b86004ffd8b32f5c39a46e05c75ee3b0/R/utils.R#L163-L166 We try to construct a replacement element for all of the `NULL` elements in the list, replacing them with...

Can you please also post a full reprex with rentrez to ensure that we fix that specific problem too? I appreciate the minimal reprex, that is definitely the right thing...

> Is there a reason not to do something along these lines? Performance? I guess? i.e. this commit from Jim talks about vroom not supporting guessing without parsing https://github.com/tidyverse/readr/commit/c88303c8f62478d752ec21381feb80bccebb619d But...