David Wells comments

Results 183 comments of


                                            David Wells

AWS Pinpoint identifier not found - Address

Oh interesting. What is `Address` used for? Yeah the object goes into the User.UserAttributes right now here https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-aws-pinpoint/src/browser.js#L301

`@analytics/google-tag-manager` adds `gtag` to `gtm.js` as well

GTM only adds one script tag here https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-google-tag-manager/src/browser.js#L66 It sounds like your google tag script is added the additional script. Check your container ID and verify what it's loading

trackEvent's state.history grows forever, takes up memory

Are your instances running serverside in a long running mode process (like express or something)? we might be able to just disable this functionality on the serverside. It’s meant for...

Instance.On listener is inconsistent with Lifecycle Events

Thanks for the issue and repro! Very detailed! Which part of the repro is inconsistent? 😅 Having trouble parsing that out of the console.logs of example

Adjust event name in enrichment plugin

This is interesting one. Changing `event` isn't setup right now. Would be a good future improvement tho Right now you can send provider specific events like this: ```js /* Send...

Consent-aware storage mechanism

I like this idea @dobesv https://github.com/DavidWells/analytics/issues/346#issuecomment-1331674180 I need to implement some additional GDPR features coming up in the new year... It will likely be in the form of a plugin....

analytics.reset() does not reset userId in google-analytics plugin

Yeah looks like ga4 and ga3 plugin don't have a `reset` defined like so https://github.com/DavidWells/analytics/blob/0fb5860bf2b7e2c180dbc0462c66c6bd36331fde/packages/analytics-plugin-original-source/src/index.js#L40-L43 so there isn't any cleanup action happening in them. Only the libs values are getting...

David Wells