David Rothstein
David Rothstein
Only had time for a quick look (and am AFK tomorrow) but it looks great to me -- thanks!
I found a couple relatively minor problems here and created followups for them: - https://github.com/Automattic/wp-calypso/issues/69142 - https://github.com/Automattic/payments-shilling/issues/1167 Also a followup for the (preexisting) issue regarding the implication that you can...
I did a quick test and saw that most of the issues from my comment at https://github.com/Automattic/wp-calypso/pull/67090#pullrequestreview-1105154046 are still present (in particular the first, "We seem to have a double...
I did another round of brief testing. >I tested Jetpack subscriptions via jurassic-ninja and it should be fine. For me, the modal is still appearing for Jetpack. Note that you...
I tested again and am still seeing some of the previously-mentioned problems, in particular: - For a non-refundable subscription with auto-renew on, going through the cancellation flow still results in...
There's also a UX issue here on mobile specifically -- once you scroll down to the bottom of the list and select an add-on, you are kind of stuck, until...
settings.php needs to be writable by the web server during install, so what the code in this project is doing seems correct for that. For sites/default/files, though, it needs to...
>but this info is not available on the receipt page in calypso I'm not sure it's needed in Calypso, but it should be on the email receipt. If there's nowhere...
OK, I moved the email receipts to a separate issue: https://github.com/Automattic/payments-shilling/issues/2491 Seems like that one might be much more important than this one, though, since the email receipts are our...
>I'm going to see if I can also display the introductory offer details (date that offer ends, amount due after offer ends, regular billing term, and amount of regular renewal)...