David Griswold

Results 84 comments of David Griswold
trafficstars

> Could also move the enum definitions to a different .h and import that into settings.h and framebuffer_layout.h. Like maybe to src/common/common_types.h or something similar in the common directory (or...

Okay, so we seem to have four possible solutions to this annoying linux compilation issue, all with upsides and downsides. I'm going to list them here and then maybe we...

> @DavidRGriswold I was playing around with this PR on Android using Option 1 (Rename all uses of the word None in both cam_params.h and settings.h) and it seems to...

At this point, I believe this feature fully works. I went with Option 1 for the Appimage issue, since it greatly reduces the chance of this bug being introduced again...

Assuming this is likely to get reviewed and merged in the nearish future, I will code the requested screen gap feature against this code, since they clearly overlap significantly.

Latest commit reduces codebase by replacing the DefaultLayout entirely with a call to the LargeFrameLayout setting the scale to 1.0 and choosing the "Below" setting for it. This also uncovered...

If you are trying to do a really full-full test, I would recommend also testing the resolution scale feature (which seems to be most obviously used in screenshots on desktop),...

Hmm thought I fixed that but maybe it was on a different branch. I'll dig in this afternoon.

Honestly the fact that upright mode is coded completely piecemeal is kind of crazy. I should really implement a rotateLayout method that just rotates the layout after creation.

> This change appears to cause issues with existing configurations. The Large Screen layout appears to be selected, however the Original layout is displayed. The Large Screen layout must be...