David Griswold

Results 84 comments of David Griswold

I put a PR into newhinton's branch that implements this feature on desktop, if you decide to go forward with that. This is what the menus look like in the...

This is what the desktop GUI for this looks like right now. It might benefit from some grouping or better labeling, design isn't my strong suit. ![image](https://github.com/user-attachments/assets/129faa20-ffc4-4143-81cd-5b9889fc27fa) ![image](https://github.com/user-attachments/assets/fc892afa-ee1e-4e6e-88db-918417d00e19)

Most recent build adds a submenu that is working (it was so much harder than adding a combobox in settings!) The only thing I wish I could figure out but...

I am not sure what is causing this to crash on trying to build the appimage. It looks like "Above", "Below", and "None" are all being interpreted as macros from...

I'm marking this ready for review to potentially get some more eyes on it since I think it is almost all the way done. Two bugfixes are listed in the...

> I'm on my phone so I am unable to check the GitHub ci. It says the checks are in progress but when I click on them it says they...

> I don't think it is the externals. I would double check cam_params.h as it is complaining that the enum value None is a macro in an x11 header. I...

Am I really the one that added the Settings namespace call here? I guess so, because previously all the settings calls were handled in emu_window.cpp. I guess we could have...

> I don't recommend that solution I mentioned. It is hacky and a last ditch effort kind of solution. Eh, I think having macros that replace a perfectly good identifier...

> Actually it's not that bad. I can't work on this now as I have to go, but high level, just pass Settings::XXX.getValue() (which I think is an int) to...