DavidJForgeFlow
DavidJForgeFlow
Hi @LoisRForgeFlow, all fixed!
> > @hs-oerp Could you rebase ? > > Hello @rousseldenis I am trying to pull the latest updates from OCA/17.0, but it seems I don't have the necessary access....
> > @hs-oerp will you finish this one? > > Hello > > I have tried the given command but still facing the access issue. Please see the screenshot. >...
> @DavidJForgeFlow What do you think adding 'pricelist' term to module name? As this is more explicit. So, sale_display_pricelist_surcharge' Changed!
> @DavidJForgeFlow would it be possible to add some test? Makes sense to add tests here, I will note it and add them when I have time!
@JordiMForgeFlow @rousseldenis Tests added!
> @DavidJForgeFlow test seem to be failing, could you check? Seems an error common in all 16.0 PRs. If monday keeps happening I will investigate further!
@JordiMForgeFlow there is a conflict between two modules that cannot be installed at the same time: account_invoice_triple_discount and account_invoice_fixed_discount. The test including them fails, the other one works. Should we...
There is a PR open trying to fix this error: https://github.com/OCA/sale-workflow/pull/2885. As the module sale_triple_discount is also failing by adding this modules as rebel: https://github.com/OCA/sale-workflow/pull/3629. Let's wait until @grindtildeath fix...
@JordiMForgeFlow @rousseldenis This is now ready to merge!