Dave McEwan

Results 57 comments of Dave McEwan

@dalance There are a few rules which I think could be named more consistently to help new users find them in alphabetical order. Would you accept these renames (using the...

I like this idea, and it's relatively simple to implement. Just need to check that the 3rd element of every `ParamAssignment.nodes` is `Some(_)` rather than `None`, but only within a...

Hi @Masshat, This is actually my favourite rule, though the consequences/purposes are a bit subtle. I recommend this rule particularly to students and new designers to ensure that they can...

FYI, I'm working (slowly) on PR #170 to add explanations for each rule, but it's taking a while with other life/work getting in the way :p

@AlexLao512 That's a good point about the surrounding environment of other rules, i.e conjunction of rules, AKA ruleset. This rule works together with `explicit_case_default`, `explicit_if_else`, and `default_nettype_none` to give a...

> There is a philosophy for individual rules to be put in #170 but we might want to put together a wiki page with a curated rule set and philosophy...

@Masshat Does this conversation answer your question? If not, what is unanswered? Otherwise, would you close the issue please.

Another pre-elaboration alternative (similar to Verible) is svlint: https://github.com/dalance/svlint I'm adding on rules for naming conventions in my "free" time.

@atyrberg Are your cases helped by #61? If not, would you consider adding some tests in `sv-parser-pp/src/preprocess.rs`? I think that adding tests is a bit easier now.

@nikhenri Would you close this if you're satisfied?