DarrylWong
DarrylWong
I agree its a bit confusing but of the given solutions, `CustomOptions` approach seems fine to me. >Note that we could also stick with ConnOption and use reflection, but only...
bors r=srosenberg,darrylwong,herkolategan
Smoke test of mixed version tests: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/19957442?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true
TFTRs! bors r=herkolategan,srosenberg
High level question, is there any downside to use the bulk create API? i.e. can we eventually flip this to true and get rid of the non bulk VM creation?...
>Unintuitively, we also use bulk VM inserts to create a single VM, allowing GCP to choose the best zone for that VM Ah that sounds nice! Although it tends to...
I think the maximum distance plan Stan sent reveals a bug: https://github.com/cockroachdb/cockroach/blob/f51bd2d3d999249d7911f574a7d03ac49fe3d214/pkg/cmd/roachtest/roachtestutil/mixedversion/mutators.go#L421-L434 `_, runHook := s.impl.(runHookStep) ` should mean that we restart before running any user hooks. However we can...
Small potential lead on this. I had some time over the weekend to read a bit of the managed service code for spinning up serverless clusters, mostly trying to figure...