cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

roachtest: global monitor expects specific process deaths

Open DarrylWong opened this issue 5 months ago • 2 comments
trafficstars

This change refactors the global test monitor to expect specific process deaths rather than a number of any process deaths. This change is to support the failure injection framework (https://github.com/cockroachdb/cockroach/issues/138958) as well as failure injection in mixed version (https://github.com/cockroachdb/cockroach/issues/148084). In the future, we will want to be able to tell the state of the cluster/nodes from the monitor.

This change also refactors the mixed version tests to use the global monitor, as well as deprecates the old cluster monitor. See individual commits for details.

Informs: https://github.com/cockroachdb/cockroach/issues/118214 Release note: none

DarrylWong avatar Jun 17 '25 15:06 DarrylWong

This change is Reviewable

cockroach-teamcity avatar Jun 17 '25 15:06 cockroach-teamcity

Smoke test of mixed version tests: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/19957442?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true

DarrylWong avatar Jun 17 '25 18:06 DarrylWong

TFTRs!

bors r=herkolategan,srosenberg

DarrylWong avatar Jun 24 '25 20:06 DarrylWong