Cyrus Leung

Results 137 comments of Cyrus Leung

@njhill I see that you are working on #3512. I suppose it would be better to get that merged before continuing with this refactor.

Seems that #4032 fixed the LoRA bugs, however `entrypoints-test` is still failing.

**Update:** I found that it is due to a bug in my refactored parsing, my bad. I have fixed it just now.

@njhill The tests now pass. To move on with #3978, perhaps we can merge this PR first?

> **Update:** I found that it is due to a bug in my refactored parsing, my bad. I have fixed it just now. I'm updating `test_batch_completions` to better catch this...

No worries. Do note that I have ported some of the changes (mostly related to type annotations, which was the original intent of this PR) to #4355, so perhaps we...

Alright, #4355 has been merged so I have updated this branch accordingly.

Heads-up: I have copied `OpenAIServing._parse_prompt_input_or_inputs` to `vllm.inputs.parse_and_batch_prompt` in #4328. If that other PR is merged first, I'll make the change in this one accordingly.

> cc @rkooo567 is this file checked by mypy? It is strange that it passes mypy checking. I guess that type checking is disabled for imported items due to setting...

I have added support for single image input in #3978. ~~However at this stage, VLM config is required when complex object is passed even when only text is passed. The...