Declan Rieb

Results 6 comments of Declan Rieb

I expect the get_set_specials will fail, as describe in other comments. I think I've addressed most of(all?) your other comments. Thanks for looking at it. Most of the 'gardening' is...

The PR check (check_commit.sh) Failed with an error: Change modifies an image and (potentially) a driver for a possible upgrade breakage What image? and I've only changed one driver, which...

I've now tried asking copilot for help with the PR checks failure. It showed me how to run the ./tools/check_commit.sh origin/master by hand, but it gives me no more information...

OK. I was wrong about the test command. it's essentially saying if the strings `modified_img` and `modified_py` are both of non-zero length, the `fail` should happen. ``` modified_files=$(git diff --name-only...

**NVM the PR problem. and my rants in the previous two comments.** I think I've solved the `PR` checks problem. I hadn't synced my master with yours, and so many...

I did put the `tests/test_edges.py` change that you suggested into this PR. Thanks. I hope the official checks will use the new test instead of the old. The five radios...