Daniel Von Fange
Daniel Von Fange
# Code Review - Vault Slow Drip ## Requirements We have two goals: to stop donation attacks and to provide fine grain yield control. This PR takes every source of...
The core attack we are trying to stop is someone sending the OETH to the wOETH contract, causing the value of wOETH in OETH terms to go suddenly up. It...
It also feels really scary that were are minting and burning using old ratios. That doesn't cause rektness?
I misread the code and got the credits per token and the credits switched. Nevermind everything I said - I'll have to stare at it more!
Invariants I can think of: - Assuming credits creditsPerTokenHighres in OETH only moves down, then woeth.convertToAssets() should only ever move up - We should always be able to withdraw all...
## 🔴 Requirements We want to make our non-rebasing wrapper contracts able to be safe to be borrowed on lending platforms, not just used as collateral. There’s a little known...