Daniel Von Fange

At first I was excited about blocking zero approval transferFroms, but after more thinking, I think it's a bad idea. As @Amxx said, the core issue is exact amount `approve`...

I just looked on GitHub, and here's a random contract using the pattern of approve amount then call other contract. ```solidity TransferHelper.safeApprove(DAI, address(swapRouter), amountIn); ISwapRouter.ExactInputSingleParams memory params = ISwapRouter .ExactInputSingleParams({...

> This version doesn't balance the pool if it is imbalanced from the start right? It does not.

Yes, I figure with my code changes that I've invalidated all previous approvals. :D

I'm nervous as well about making changes to things that work. However, I think pretty much all of the OUSD's token's math has rounding errors once the rebasingCreditsPerToken gets small...

A nice property of the 1e27 setup is that it just works with our current code everywhere. It's not some special magic value that must be treated differently, or the...

# Security assessment of PR #1239 ## Introduction This document describes the security assessment of Pull Request #1239 *"Cleanup OUSD rebasing/nonrebasing accounting changes"* in the `OriginProtocol/origin-dollar` Github repository. The assessment...

I should: - Rebase this PR onto master - Build separate deploy files for OUSD and OETH - Have nick take a look

We could just make the front end use curve to convert it.

_Posting my mostly complete review_ # Code Review: Native Staking ## Requirements OETH should be able to deposit and withdraw ETH from SSV controlled native staking as a yield earning...