Danny Thomas

Results 106 comments of Danny Thomas

@novaterata rules that have auto-fixes tend to not be descriptive, because they can be fixed automatically by `fixGradleLint`. `unused-dependency` is a little confusing, because it currently covers used but undeclared...

I recently fixed an unclosed input stream bug (https://github.com/nebula-plugins/gradle-lint-plugin/releases/tag/v7.2.3). What version of the plugin are you using?

@gituser2202 what version of the plugin are you using? I've checked the classes that open jars and they're all seem to be using {{withClosable}} and I wouldn't expect dangling file...

The lint rules are defined here - https://github.com/nebula-plugins/gradle-lint-plugin/tree/master/src/main/resources/META-INF/lint-rules I assume you're configuring {{all-dependency}} so you can configure each of those rules individually and see which one causes the leak.

We have a `com.netflix.nebula.lint.postprocess.EmptyClosureRule`, but IIRC we saw some side-effects internally and turned it off. When we revisit it, we'll update this issue.

I just added something similar to the `duplicate-dependency-class` rule when it's run at `--info` level. The violations aren't really designed with multi-line output in mind, so it'll either take a...

Sounds like we're seeing a `null` in some situtations. The original `files` case must be in `com.netflix.nebula.lint.rule.dependency.DependencyService#sourceSetOutput`, but the `canBeResolved` case must be different. @ygnessin would you mind posting a...

Thanks @ygnessin - it'd really help to have the full error when you add `--stacktrace`. That way I can see exactly where that `canBeResolved` property access is failing because we...

That's super useful, thanks. Looks like this is related to our logic to handle/replace legacy configurations. @ygnessin or others here, do you happen to have an example where this happens?...

Looking closer, I think the only place we can wind up with a null configuration is here: https://github.com/nebula-plugins/gradle-lint-plugin/blob/master/src/main/groovy/com/netflix/nebula/lint/rule/dependency/DependencyService.groovy#L159-L163 But I'm not sure how we could have any of the unresolvable...