Danny Thomas

Results 106 comments of Danny Thomas

Yes, people should _not_ wholesale replace `synchronized` with `ReentrantLock`, pinning itself is not a concern, unless it surrounds other long running blocking operations or has the potential to deadlock. Here,...

I think so, I believe we're just getting the default from upstream. We're using Brave via Micrometer/Spring. If I remember correctly, every data fetcher in DGS is observed, so these...

We've moved those applications back off virtual threads and avoiding further adoption for now, because avoiding pinning is the only way to avoid this deadlock. The lock only has to...

`configurationFiles` was added as Debian specific extension, because has a separate `conffiles` file and no concept of file directives, but for convenience `fileType = CONFIG` works. `fileType` is all you...

At a glance, you'll want to drop the `eachFile` there, `fileType` is something we add on the `FileCopySpec` and it applies to everything in the `from`.

We have 6 instrumentations, more if a service adds application specific ones - so at least 6 `getState` calls for every field. I've fixed this here: https://github.com/graphql-java/graphql-java/pull/3459