Daniel Smith

Results 44 comments of Daniel Smith

It looks like some mypy errors exist already in the repo and are causing unrelated failures in the `tools/ unittests` checks. ``` py310-mypy run-test: commands[0] | mypy --config-file=/home/test/web-platform-tests/tools/mypy.ini tools/ tools/wptrunner/wptrunner/tests/test_metadata.py:9:...

Thanks for taking a look James! I was hoping to view the changes deployed to a staging environment to see how they interact with a functional searchcache component. I usually...

Thanks for taking a look @jcscottiii and @KyleJu 😊 Sorry I took so long to respond! > Overall it would be great if you could break down changes based on...

@jcscottiii @KyleJu This PR is ready for review once again. I've tried to thoroughly explain the changes file-by-file in the description above. Hopefully that makes it a bit easier to...

Thanks for the error handling help @jcscottiii 😊 maybe looks better now.

Thanks for all the help @jcscottiii @KyleJu 😊

Hello @dbaron, I'd like to get your opinion on #2841 to ensure it adds the change you're looking for in this issue. Thanks!

It's also worth noting that I looked into `pytype`, but it seemed to have a lot of issues interpreting the code interactions with `ndb` and other datastore aspects. It might...

This change will be ready after #2341 is merged and this PR is updated to use the code in that PR.

Somehow I missed the fact that I never completed the title on this issue 😅