Daniel Ruf

Results 910 comments of Daniel Ruf

> I think this is out of scope of this library which does only and should only do compression. I still think it's nothing that should be done by this...

The library is about saving bytes / compressing your input, not performance improvements by adding code.

And also see https://caniuse.com/#feat=link-rel-preload and https://caniuse.com/#feat=script-async https://www.npmjs.com/search?q=async%20stylesheet https://github.com/search?q=async+stylesheet https://github.com/devpreview/async-stylesheet-webpack-plugin But personally loading styles asynchronically makes not much sense in most cases (FOUT, FOIC, ...). I guess you can use any...

https://www.npmjs.com/package/inline-critical has a CLI that might cover your usecase.

> It prints html output on console instead of updating the html file. See the readme. You want to pipe it to a file using `> file.html`.

I think it is better if you mention the issues at https://github.com/bezoerb/inline-critical/issues

@onebelarusianguy you might want to try the latest version. I can not reproduce it in my fork and also not in the original project: ![grafik](https://user-images.githubusercontent.com/827205/92479489-e4664800-f1e3-11ea-815d-2fe2cd476440.png) ![grafik](https://user-images.githubusercontent.com/827205/92479543-f516be00-f1e3-11ea-8618-23f1a3d15dd3.png)

In my opinion the `htmlmin:ignore` comment to ignore such markup is the correct approach for this case. There were similar issues about this and that is a valid solution.

Can you provide an example?This should work in https://github.com/terser/html-minifier-terser https://terser.org/html-minifier-terser/

Your example does not use removeRedundantAttributes but removeAttributeQuotes. Is this really the code that you have used?