Daniel Ruf
Daniel Ruf
> "rewire" was used as a replacement for require. I'm unsure if this is really needed. Is it because the method is private?
I think the PR would be good for https://github.com/DanielRuf/get-ssl-certificate-next - can you provide it there too (without the lockfile changes)? Regarding rewire, wouldn't it be better if we also export...
> The lockfile changes come from rewire. In my fork (get-ssl-certificate-next) I update the lockfile due to security reasons. And when lockfiles are changed in multiple PRs and one is...
Tests are always good and I think so far the reasoning for rewire is ok so this could stay like this - personally I just prefer less dependencies and completely...
> on pealan:master Please create a separate branch instead of using the `master`branch as this can cause merge conflicts.
See https://github.com/DanielRuf/get-ssl-certificate/pull/5/files
I will create a fork to release this and more. In the meantime you can use [patch-package](https://npmjs.com/patch-package) and https://github.com/johncrisostomo/get-ssl-certificate/pull/27.patch
How can this reproduced locally?
The changes are available in get-ssl-certificate-next v3.0.0: https://github.com/DanielRuf/get-ssl-certificate-next
> Cloudflare is used by many non-professional users for free SSL and cache. I would not say this. npm and yarn use Cloudflare ;-)