Timeout ignored on Node 12

[johnnysprinkles]

I'm doing let cert = await sslCertificate.get(host, 10000, port) for a 10 second timeout, but it doesn't seem to be firing ever. If I hit a host that just hangs, this call hangs as well for 2 minutes. Should I put together a minimal repro example?

I did notice that travis.yml only appears to go up to Node 11:

https://github.com/johncrisostomo/get-ssl-certificate/blob/master/.travis.yml

[glvangorp]

I'm actually experiencing an issue with v11.13.0 as well not respecting the timeout.

[pealan]

maybe this would help

[DanielRuf]

I will create a fork to release this and more. In the meantime you can use patch-package and https://github.com/johncrisostomo/get-ssl-certificate/pull/27.patch

[DanielRuf]

How can this reproduced locally?

[DanielRuf]

The changes are available in get-ssl-certificate-next v3.0.0:

https://github.com/DanielRuf/get-ssl-certificate-next

[pfrollo]

@DanielRuf the link to the get-ssl-certificate-next repo does not work. Would you please share the correct link? Thank you!

[glvangorp]

That was the correct link as of 2 years ago. It has since been taken down. Here's the npm package description: https://www.npmjs.com/package/get-ssl-certificate-next

[pfrollo]

I confirmed https://www.npmjs.com/package/get-ssl-certificate-next has the fix implemented and it works. Thank you @DanielRuf !