DanielPointon

Results 11 comments of DanielPointon

MAXVERTS > 512 now supported!! :) And I got some test results ``` On my branch: 824MB of memory On main branch: 2.4GB of memory ```

@james-d-mitchell is there any chance you're able to link me to the configuration for the "coverage" check run on azure? It's failing with a weird error that I can't reproduce...

> Also rebased this onto main and force pushed, this should fix the ci. It did, thanks! Ignoring the coverage test this looks good to go

> @DanielPointon I started reviewing this but realised that there are a few issues, and so I fixed compile warnings in digraphs in general in #633, and hoped you could...

> > @DanielPointon I started reviewing this but realised that there are a few issues, and so I fixed compile warnings in digraphs in general in #633, and hoped you...

> Unfortunately, the changes in this PR appear to leak memory, here's the output of valgrind: > > [mem_leak.txt](https://github.com/digraphs/Digraphs/files/14872111/mem_leak.txt) > > Thanks to @Joseph-Edwards for running valgrind. > > I...

@Joseph-Edwards thanks! @james-d-mitchell if you're okay to hold off until Monday I think I can fix this up over the weekend and save you some time.

``` ... ==4226== LEAK SUMMARY: ==4226== definitely lost: 0 bytes in 0 blocks ==4226== indirectly lost: 0 bytes in 0 blocks ==4226== possibly lost: 0 bytes in 0 blocks ==4226==...

@Joseph-Edwards ``` ==3459== LEAK SUMMARY: ==3459== definitely lost: 0 bytes in 0 blocks ==3459== indirectly lost: 0 bytes in 0 blocks ==3459== possibly lost: 0 bytes in 0 blocks ```...

I'll be working on this following discussion in weekly meeting.