Daniel Anderson

[BUG] #1435 breaks automated builds on Windows

8

**Describe the bug** My CI automatically clones the main branch using CMake FetchContent. My Windows CI builds are now failing as of #1435. Specifically, the following linker error appears: ```...

folly::ConcurrentHashMap crashes under high contention

1

When under significant contention and with a specific key distribution, `folly::ConcurrentHashMap` fails checks inside `HazptrObjLinked.h`. I've reproduced this on multiple machines. **OS:** Ubuntu 20.04.6 LTS (reproduced on Ubuntu 22.04) **Compiler:**...

`` was missing a case to handle Cygwin (which doesn't identify itself as either Windows or Linux), and was incorrectly defining a function with a name clash against a Clang...

Fuzz testing could be added to the CI workflow for better security.

We don't currently have any dependencies, and plan to keep it that way, but this is a requirement of [FLOSS Best Practices Criteria](https://www.bestpractices.dev/en/criteria/0).

### group_by_key The performance of `group_by_key` sometimes suffers on multi-socket machines, despite scaling fine on a single socket. Its implementation could possibly be improved. `group_by_key_sorted` does not seem to have...