Daniel Hara

icon indicating a website link https://www.danielhara.me/page/about icon indicating an email [email protected]

icon company Software Engineer @Uber icon location São Paulo icon location Software Engineer @Uber | Computer Engineering class of 2018 at @ Instituto Tecnológico de Aeronáutica (ITA)

Results 6 comments of Daniel Hara

Cannot read property 'length' of undefined at windowCleaner

I guess this has to do with this jsdom issue: https://github.com/jsdom/jsdom/issues/1636

Outdated dependencies.

PR to solve the peer dependency issues: https://github.com/styleguidist/react-styleguidist/pull/2012

Children's key is missing

Looks like this issue is still happening in version 15.0.0: Input: ```js import React from "https://esm.sh/[email protected]"; import reactElementToJsxString from "https://esm.sh/[email protected]"; console.log(reactElementToJsxString( )); ``` Output: ``` " " ``` To reproduce:...

Children's key is missing

@armandabric , @yoyoyooo , I've created this PR to fix this bug: https://github.com/algolia/react-element-to-jsx-string/pull/841 🚀

[Bug]: key prop missing on generated source code

Hi there! Yes, I'm also experiencing this issue and it looks like the bug comes from https://github.com/algolia/react-element-to-jsx-string/issues/301, and I've opened a PR there to fix it.

fix: keep key in child elements, fixes #301

@armandabric , any feedback on merging this? :)