DanielEScherzer
DanielEScherzer
Failure is from HTTP 405 error when uploading code coverage, which I think is unrelated to the actual changes
> > Done for matching 907, after 908 is merged I'll add test cases there > > @DanielEScherzer I've merged both #907 as well as #908 now, so you should...
> P.S.: I see there is another merge conflict. Sorry about that. PR #948 also touches that same sniff, so you may want to hold off resolving the conflict until...
> The `index` parameter should get described, too. Maybe: "Index of the parameter (zero-based)." Done
> ### File::getMemberProperties() and File::getMethodParameters() > Before I give an opinion about the current proposals, I'd like to understand the reasoning behind them better, so would you mind expanding a...
As of 5.5.2 a `PhanTypeMismatchReturn` is emitted > input:3: PhanTypeMismatchReturn Returning (a Generator due to existence of yield statements) of type \Generator but test() is declared to return object[] See...
Appears to have been done in 69d87e8520a52ba60a185e3b50066f589ddfde44 for #4442 which added > "PHP warns about private method {METHOD} being final starting in php 8.0"
> [Deprecate returning non-string values from a user output handler](https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_returning_non-string_values_from_a_user_output_handler) should be removed from the list, this got reverted
> > > [Deprecate returning non-string values from a user output handler](https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_returning_non-string_values_from_a_user_output_handler) > > > > > > should be removed from the list, this got reverted > > [@DanielEScherzer](https://github.com/DanielEScherzer)...
As of 5.5.2 the PhanRedundantCondition is no longer reported, see [demo](https://phan.github.io/demo/?c=DwfgDgFmCwBQcGMA2BDAzmgBAFQKZoBdMBvOTczAMwFcA7BAgSwHtbMD8CB9BVgE0ZNWKJAAoAJGBQAnFAFsAlCTIVVjSplEBCRhlwEJU2XIDaAckqNcSPmYC6CpaVirXFSTPnnL123cwAvJgATAAMANwqbgC%2BcFGu6poexuYAHvaBQcFO8W7kyV5m6f5BtNRISJEuebHVbtL61NJsBXJVqrWqNPRCbHLMApQAnhIAbiLU%2BDl1ruLjSJNo5swEELjSGVnteXMT%2BIGY4qu6ALQAfByEPPyCLLQiY3toCttuZgACkCi0J3y4AEbUADmJ3G0kO80WZles1SB12C3waXsMNUAHo0ZgAGIiNC4TBgZhoW6jfEABQg3wASrg%2BHQ%2BN8CABhG69TA0um0Bm0IgoAgcORgIgEZiYBDoIjiOHMDQEIZgfFlCrsUW4QVy3IURKiNVCkZSxzKGZ5TC4BAQUUAIgAyigAO6HVIAHVoltRFE6Hrg0SAA&php=84&phan=5.5.2&ast=1.1.3&plugins=549755813887)