DanielEScherzer
DanielEScherzer
As noted above and elsewhere, defaults for promoted properties are only applied to the constructor parameter, not the property itself. We should say something like > Note that for promoted...
All failures and errors are unrelated in the PHPUnit tests (mostly mbstring and Grapheme related)
@fabpot is there anything I can do to move this forward?
> Thank you for the PR! However, I'm not sure how to document this. I wasn't sure either, but figured a patch was better than the php-src report just sitting...
The failing check `continuous-integration/styleci/pr` says > We were unable to access the repo or commit to analyze it. So I don't think that is something that I can fix
> Have you considered using the `'position' => 'placeholder'` option instead? It allows much more flexibility, such as providing a heading (which could be made linkable thanks to [the Heading...
@colinodell I've fixed this so that the HTML is valid, but now this is a tiny BC break because of the new TableOfContentsWrapper class that I introduced. Is this BC...
> One additional question: how did you determine where in the (huge) `PHP::tokenize()` method, the polyfill should go ? It is currently between the tokenization blocks for `T_ENUM_CASE` and PHP...
@jrfnl my understanding is that this is waiting for re-review, just want to check that you aren't waiting for me to do something and have us both just wait
> @DanielEScherzer Thanks for the updates you've made. > > While looking at this PR again - and in particularly, looking at the changes made to the predefined `Tokens::$*` properties,...