Daniel Biegler comments

Results 46 comments of


                                            Daniel Biegler

Cycling through quantity of an item in the cart doesnt update properly

@gioboa Now the reactivity of the subtotal is broken :laughing: But thats just a tiny detail. Afterwards I slowed the network down so you can see what I mean more...

Asset Transformation focal point and withoutEnlargement => sharp bad extract area error

Ohhh, good catch. Problem here is that resizing is a fundamental step when cropping to a focal point and depending on the params you must enlarge the image temporarily so...

User is not redirected to User Profile if registered with No "Email Verification"

Ahhh nice catch! You're correct. For the verification we get the id and redirect: ```ts const id = await service.verifyRegistration(value); return res.redirect(`/admin/users/${id}`); ``` But for the registration we continue normally:...

Error when new user is created and role is left blank

Just tested this, but under sqlite, and it works for me. Mh your response should also not be code 204 but a 200 since we do return the primary key...

Add user limits

> But ItemsService.updateBatch calls RolesService.updateOne But it instantiates a new generic `ItemsService` in there? https://github.com/directus/directus/blob/47c438b4e3e2611f16ab372bea66d6396cd13cca/api/src/services/items.ts#L552-L584 Does that still call RolesServices' functions over its own somehow @hanneskuettner ?

Add support for custom URLs for email verification

Hey @shubham-am-i it sounds like youre not on the latest version `v10.11.2` - it is confirmed to work. For example: ``` USER_REGISTER_URL_ALLOW_LIST=http://asd.de ``` And then an API request like the...

Assign Permission to Users per Channel

Yes please. For anyone that wants a concrete example, see the POC multi vendor plugin inside [the service](https://github.com/vendure-ecommerce/vendure/blob/1b4c50fffcac08d0f256eff875ddd1023499a580/packages/dev-server/example-plugins/multivendor-plugin/service/mv.service.ts#L138-L172). https://github.com/vendure-ecommerce/vendure/blob/1b4c50fffcac08d0f256eff875ddd1023499a580/packages/dev-server/example-plugins/multivendor-plugin/service/mv.service.ts#L138-L172) You gotta create `${shopCode}-admin` roles per seller which becomes a PITA...

Daniel Biegler