Danny Tuppeny

Results 1798 comments of Danny Tuppeny

@Number-3434 I can't reproduce this - I see "other" used for the type parameters: ![image](https://github.com/Dart-Code/Dart-Code/assets/1078012/75727b3b-d74b-4280-a4b7-1c031aeafa85) And I see the same in the golden tests for the grammar: ``` >class A1...

Not sure if it's obvious/known, but just in case - this issue isn't isolated to the bots, it prevents syncing to master for development too (see https://github.com/flutter/flutter/issues/160654 - I also...

> Ensure that the VS Code embedded web views support WasmGC (see [background information on Chromium and V8](https://docs.flutter.dev/platform-integration/web/wasm#background)) The current version of VS Code uses Chromium v120 which sounds like...

@kenzieschmoll > Patch the changes from https://github.com/flutter/devtools/pull/7867 and https://dart-review.googlesource.com/c/sdk/+/369100. Then run devtools_tool serve --wasm. The first has already landed but I patched in the second. I added "--wasm" to my...

Seems like the issue is that `window.crossOriginIsolated` is `false` ![image](https://github.com/flutter/devtools/assets/1078012/2c867693-43ad-40af-8464-4504386c90a9) The [docs here](https://developer.mozilla.org/en-US/docs/Web/API/Window/crossOriginIsolated) confirm the headers in the CL above are required, but I see those are also set: ![image](https://github.com/flutter/devtools/assets/1078012/4172d811-367b-4384-9a52-74e4da9c5583)...

I tracked this back to https://github.com/microsoft/vscode/issues/186614. It seems cross-origin-isolatation is currently disabled by VS Code. When it was enabled the were performance issues that resulted in it being reverted. I...

Thanks! Adding that header on its own didn't work, but then I found I needed `allow="cross-origin-isolated"` on the iframe. With that, the flags are all true and the wasm version...

@eyebrowsoffire that flag didn't seem to work: ``` C:\Dev\Google\devtools\packages\devtools_app > C:\Dev\Google\devtools\tool\flutter-sdk\bin\flutter.bat build web --wasm --name-section --pwa-strategy=offline-first --no-tree-shake-icons Could not find an option named "name-section". ``` I tried `--no-strip-wasm` (which I...

> There are no casts in that function from the user code that I can see It's assigning `responseValue` (if not `null`) to `enabled`. `enabled` is a bool, `responseValue` is...

Since that code looks bogus to me, I retried in non-wasm mode and I see errors in the console - however unlike the wasm version, it doesn't stop DevTools loading...