Danny Tuppeny

Results 1798 comments of Danny Tuppeny

When not debugging, the analysis server provides the hover. When you are debugging, VS Code extracts the expression under the mouse and sends it to the debugger for evaluation. Based...

This is very odd... I can repro running from source and added some `print`s, and it seems like it is creating the file: ``` PS C:\Dev\Google\flutter\packages\flutter_tools> ../../bin/dart .\bin\flutter_tools.dart --version; ls...

@christopherfujino here is the issue: ``` Inside _FlutterVersionGit.ensureVersionFile Writing 3.19.0-13.0.pre.32 to LocalFile: 'C:\Dev\Google\flutter\version' using ErrorHandlingFileSystem Calling LocalFile("C:\Dev\Google\flutter\version").writeAsStringSync() Exists now? true Calling LocalFile("C:\Dev\Google\flutter\bin\cache\flutter.version.json").writeAsStringSync() Exists now? true Deleting the new version file!!!!!!...

Ok, the reason this doesn't happen on beta is because of this early exit, which prevents the constructor running that deletes the file: https://github.com/flutter/flutter/blob/ccb2b4439a430d4a736bcb294ba8f00be79fc66c/packages/flutter_tools/lib/src/version.dart#L172-L174 So the issue is isolated to...

Not sure if it's the same thing, but I just noticed that the GitHub actions are often failing the coverage step because the Flutter version is reported as 0.0.0-unknown: ![image](https://github.com/flutter/flutter/assets/1078012/fb847133-38e0-4300-aa2a-59b06a9d427c)...

This came up again in https://github.com/Dart-Code/Dart-Code/issues/5226, where we were using old versions of DevTools page IDs because we thought we were on an old version of the Flutter SDK. @christopherfujino...

Ah, gotcha. Should there be an `ensureVersionFile` call somewhere _after_ that `fetchTagsAndGetVersions()` then? Oddly, I can't see where `fetchTagsAndGetVersions()` (or the constructor it calls) actually fetches any tags (seems like...

Some additional info I just noticed: - running `flutter doctor` results in the file being deleted and not replaced - running `flutter --version` results in the file being deleted and...

Thanks! I implemented a few tweaks in Dart-Code (such as calling `flutter --help` directly after `flutter doctor` in the case where we force initialization) which I think will reduce the...

Ah, that sounds reasonable. Currently we're just reading the version the same way for Dart and Flutter (Dart also has a `version`), but reading the JSON if it is there...