Danny Tuppeny

I understand, but it's far easier for me to review a single diff than go through all 28 commits and review them individually. I don't think changing the tabs to...

np, I haven't finished setting up testing for the dart-syntax-highlighting repo yet. But what we could do in the meantime is add more files in https://github.com/Dart-Code/Dart-Code/tree/master/src/test/test_projects/grammar_testing/lib that cover the cases...

I'm struggling to repro this. The first refactor is a little slower (but only maybe 1-2 seconds) and from the logs looks like it was because the analyzer will still...

Thanks for the log! The relevant parts are here: ``` [15:55:48] [Analyzer] [Info] ==> {"id":"34","method":"edit.getRefactoring","params":{"file":"C:\\git\\my-project\\lib\\widgets\\app_button\\app_button.dart","kind":"RENAME","length":1,"offset":143,"options":{"newName":"MyButton"},"validateOnly":false},"clientRequestTime":1581432948177} [15:55:53] [Analyzer] [Info]

@mikeesouth thanks for the extra details! > An interesting observation is that even if I've been running the project for say 30 or 60 minutes and then I rename a...

I tried to repro this again recently, and I came across a performance issue - but it was only triggered in very specific circumstances (where you open VS Code with...

Please see the request in the comment above. If someone can share a project this happens with, along with an instrumentation log (and confirm whether `dart.autoImportCompletions` affects it), I'd like...

@mmcc007 if you're able to track down which extension triggers this, I'd be interested in trying to understand why to see if it can be fixed (either here, or in...

@szotp I think I've seen it fairly early on, but I also haven't been able to reproduce it much. @bwilkerson @scheglov - do you have any ideas why the first...

@bwilkerson ah, interesting! Is that done separately to initial analysis (or rather - can it continue after initial analysis completes)? If so, any pointers to where I might find it...