Danny Tuppeny
Danny Tuppeny
@bwilkerson @pq there is some specific handling for expressions that create Flutter widgets here (added [here](https://github.com/dart-lang/sdk/commit/efb5c5ddc5f3b17e706a69da80964ce7a0eb73df) as part of [this issue](https://github.com/flutter/flutter-intellij/issues/551)): https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart#L111-L112 The same logic is used in a few...
For comparison, could you get the same log when you don't include `"cwd": "src"`? I don't see anything obviously wrong in the log. The only difference this should be making...
Confirmed this works as expected using the new SDK DAPs too.
I'm not sure what I tested above, but I still see this failure today. I believe the issue is that without `cwd` we don't detect the project as Flutter, and...
Ah, no worries. I did a little more digging (see https://github.com/flutter/flutter/issues/110260#issuecomment-1227272789) and I think that `flutter attach` is probably not intended to be used with apps launched with `flutter run`...
Thanks for the contribution! I haven't had chance to look at this in detail yet, but I'll try to do so next week (although I may wait until you think...
@pouyakary I had a quick compare of this versus the current grammar. Some items like `get` `set` as identifiers look better now (they're no longer coloured as keywords), however it...
@pouyakary yep, I think we should treat `String` as a class. This matches the existing grammar and semantic tokens. I understand `String` is perhaps a little odd because it could...
Cool, thanks! I've started some work to try and get some tests into the dart-syntax-highlighting repo, which should make it easier to verify the impact of these changes. I think...
> Fixed the problem with nested generics Nice! I just discovered that issue recently while working on some testing support for this and hadn't gotten to looking at it yet....