Danny Tuppeny

Results 1795 comments of Danny Tuppeny

It seems like a bug, though not here :-) If you disable semantic tokens in VS Code (which means it'll be coloured according to this grammar) then it'll show the...

I've had a few issues raised against Dart-Code related to fvm, although it's not clear to me what's happening in the call stack above to know if any are similar...

The reason it's showing up in master is that the filtering is done by `_PubFilter` and `shouldInclude` first checks `uri.isDart` and if it is, it checks `FileStateFilter.shouldIncludeSdk` which returns true...

Thanks - I like the idea of this, however I have a goal to try and make the textmate grammar and semantic tokens more similar (because one is applied immediately...

@RedCMD > VSCode has been setup in a way that semantic highlighting should only ever enchance the TextMate grammars > by highlighting things that TextMate just cant (context aware syntaxes...

Isn't that essentially the same request as https://github.com/microsoft/vscode/issues/163292?

> //cc @bkonyi there seems to be multiple DTD and flutter tools processes in the screenshot above, not sure why there needs to be multiples of them. I can only...

@FMorschel do you have code to repro this? I tried adding the following test to `DartEditBuilderImpl` in `pkg\analyzer_plugin\test\src\utilities\change_builder\change_builder_dart_test.dart`: ```dart @soloTest Future test_sourceEdit_issue62146() async { var path = convertPath('$testPackageRootPath/lib/test.dart'); var builder...

Thanks! The issue here is that `sourceChange` is a getter which tries to build a new edit each time. However, it calls `finalize` on the internal builders which mutate state...