Danny Tuppeny

Results 1795 comments of Danny Tuppeny

@kenzieschmoll I think we have two options here: 1. We reload all embedded Windows with the new theme on the querystring 2. We have some API to update the theme...

Maybe some of these things should live outside DTD? For example DevTools posts keypresses up to VS Code so you can still open the command palette when an embedded window...

Splitting sidebar into its own issue at https://github.com/Dart-Code/Dart-Code/issues/5071 since that has a simple fix - we can just refresh it because it doesn't have much state and everything except the...

Yeah, I think something along those lines. There are some slightly awkward things here though... In VS Code, we can't access information about the theme from the extension (it's a...

Latest version of Dart-Code/Flutter master will use DTD for the sidebar. We should look at defining an event for the Editor stream for the theme changing (and documenting it at...

I hadn't got to it yet, but I had planned. Unfortunately, as with many things, it's complicated in VS Code 😄 We get an event to tell us when the...

While documenting this, I realised that there are some more nuances to this... In VS Code we have two different background colors - the sidebar is slightly lighter than the...

To capture some offline discussion: - we'll support theme changes as an event over DTD and an equiv event over postMessage - VS Code will use postMessage and provide the...

I've some PRs in progress that will fix this (including updating the sidebar to no longer refresh, but use the new method, and having different colors for the sidebar/editor to...