Daniel Sheppard

Results 244 comments of Daniel Sheppard

> We should really have a code standard for this - validation in one central place. Note: Asking, if you don't think it's feasible please push back. You cannot check...

FYI: Tested this, the code between the form validation and the serializer validation is unfortunately too different to really support a common check (ex: form uses `self.get_intial_for_field` to obtain the...

I think it is worth the addition

I think it is worth the addition

> At this point I don't know how to fix this migrations issues. I wasn't able to replicate it or fix it locally as pipeline suggests. You will want to...

I fixed it for you, hopefully this one completes

Not going to go forward with this, in it's current state. The interface model will not change, as it is similar to the actual implementation where ospf is enabled per...

> As I understand it, all OSPF neighbors must share the same area, authentication, and timers. Would you be open to a model that groups these fields, or just authentication?...

This is because of the recent GraphQL changes. I might remove GraphQL unless someone is specifically using it.

> I'm afraid this still doesn't address my primary concern: Validation of cable state needs to be performed _prior_ to the point where we're generating cable paths. (Again, the original...