Daniel Sheppard

Results 244 comments of Daniel Sheppard

This is expected (but annoying) behaviour as per: https://code.djangoproject.com/ticket/1130 Two options are possible: 1. Rewrite `get_field_value` to dynamically determine if the field is capable of returning multiple values 2. Create...

Proposed rewrite: ``` def get_field_value(form, field_name): """ Return the current bound or initial value associated with a form field, prior to calling clean() for the form. """ field = form.fields[field_name]...

After re-reviewing the code, I realised I made an error before trying to fix this: On March 31st, when fixing another issue, the code around this function changed from: ```python...

Fixed by: https://github.com/netbox-community/netbox/issues/19023

> AFAICT the only change actually needed to address #14044 is to ensure that a null name is always treated as an empty string. (Currently this is true only when...

Hello @adparis99 There is a lack of information here. What makes you think that this does not work with 4.2.4? I am able to run the plugin just fine.

Cisco ISE ERS uses an interesting setup, that might work here. This would be incredibly breaking, but I do like it: ``` { "_metadata": {...} "Device": {...} } ``` It...

Can you check the latest release when you get a chance? I think I fixed this with some other fixes (might be wrong). If not, feel free to PR it.

@francesco-noc Is this ready for review again?

Per maintainer meeting, need to refactor logic to try and streamline the checks.