Dan Klishch

Results 73 comments of Dan Klishch

Now with refcount bug fix ported!

@ADKaster ~~This's why I tried to ask about this whole thing on Discord before writing any code but nobody seemed to care~~ > Why shouldn't we link against the C...

Also, look at [this](https://github.com/SerenityOS/serenity/pull/22311/commits/3b0a5c05499655e89600144b84f13cde03622d3f#diff-f20ad942628a37ac357572f5e213efb1b204ec53b98391d195b62de5f95f976a), for example. Seems like it's so much nicer to be able to use C++ APIs inside LibC.

> Conflicts with the Json change, which has a similar commit in this PR (same commit? lol). :facepalm:

By memory layout I meant things like allocations and SSO. So the main advantage is code deduplication. The other argument I had is the potential LibWeb speed up because of...

> Use StringBuilders instead of to_byte_string(). And ```cpp for (auto entry : entries()) if (entry.name == name) return entry.value; return {}; ``` would be both always infallible and shorter... And...