Fabien COMBERNOUS

Since status is `ACCEPTED`, i supposed yes. And also the comment on ticket i opened : https://tickets.puppetlabs.com/browse/PUP-9332?focusedCommentId=724011&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-724011

Since [spec_helper_acceptance.rb](https://github.com/voxpupuli/puppet-nodejs/blob/master/spec/spec_helper_acceptance.rb) does not add any core and acceptance tests pass, IMO the README.md file is correctly written.

Hi @jameskirsop looks a good idea. Can you propose a PR ?

Here we are also interested by the fix of this issue.

Hi @edestecd you added unit tests, and you can let the file in the PR. This is interesting to have more tests. But @bastelfreak talk about acceptance tests not unit...

In this module, you can find : * the [helper_acceptance](https://github.com/voxpupuli/puppet-php/blob/master/spec/spec_helper_acceptance.rb). The role of the helper is to prepare system under tests (SUT) to be ready for being able to receive...

> I haven't yet addressed what you said about my manage_services. I am trying to figure out how to have this discussion with you. You can ask to VP members...

Initially i thought that code is managing `systemd-timesyncd` but was wrongly named `ntp`. But it is really `ntp`. So i agree that a component module should be used to configure...

I am not a RedHat like user, this module is special because it manages several things. So we should move to `puppetlabs-ntp`.

As a temporary workaround to be able to install Lemur for my tests : * remove line about `angular-file-saver` in file `bower.json` * run command `npm install angular-file-saver --save-dev` *...