puppet-letsencrypt
puppet-letsencrypt copied to clipboard
voxpupuli
Add support for systemd service and timer units to renew.
This also adds support for naming services to restart with systemd instead of long-handing it all. It also adds support for managing firewalls using firewalld for systems that are not meant to be http/https accessible at all times.
These three are essentially the same support and it is difficult to break it up
Again, I would love help knowing quite how to create the CI acceptances for this.
This is failing because I do not know how to tell travis how to pull in camptocamp/systemd. There may be other problems. I would appreciate some help knowing how to do this as I am not finding it in the travis documentation.
I haven't yet addressed what you said about my manage_services. I am trying to figure out how to have this discussion with you or just carry this is my own fork of this (not the entire patch, just a small amount of it). I believe I have addressed everything else. It looks like it is going to pass Travis CI now.
I did have a small mishap with git, so if it appears things went sideways, please point it out. Same if I missed things.
I haven't yet addressed what you said about my manage_services. I am trying to figure out how to have this discussion with you.
You can ask to VP members on #voxpupuli on IRC preferably, or Slack.
I have still left in the short cut for restarting services. I am still trying to figure out the best way to do this as I need/want this locally, but want to maintain minimum changes.
Dear @treveradams, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Dear @treveradams, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @treveradams, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @treveradams, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @treveradams, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Rebased, but now I'm not sure this is really needed since the distribution package (at least on Debian) provides systemd units for certbot.service and certbot.timer: https://packages.debian.org/bullseye/all/certbot/filelist
Looks like that's the case on Fedora-derived distros too: https://src.fedoraproject.org/rpms/certbot/tree/f35
I agree with @kenyon that we should encourage distro renewal scripts (cron and/or timer). For the Red Hat OS family that's certbot-renew.timer and for Debian there's certbot.timer. We should also encourage the use of the native renewal hooks.
Dear @treveradams, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks