DakkJaniels

Results 159 comments of DakkJaniels

I think this should be fixed with #5243. #4999 switched the shrine missiles to TARGET_MONSTERS for some reason, which I think was incorrect, as this causes the Add[missile] functions to...

> it was switched so that `sourceType()` will return `MissileSource::Player`, else `sourcePlayer()` will return `nullptr`. so change to TARGET_BOTH so it uses mana?

Ok switched it, It did seem to work fine for the few shrines I was able to quickly find and test with (found Holy and Magical) for `TARGET_PLAYERS` . It...

If you aren't using git (not clear to me how you started), the instructions say you have to supply the version number too. https://github.com/diasurgical/devilutionX/blob/master/docs/building.md

Switched to TARGET_BOTH so the spell still won't use mana, and SourceType() and sourcePlayer() will return the player (if that matters for these shrine spells)

I was thinking the same thing - but I wasn't sure if there would be any time when it would be set as one variable in the union and accessed...

Maybe just rename the "Quit Game" to "Exit Diablo" (or Hellfire), so unified with the language used in the main menu, and it's more clear you are exiting the program...

Also, the exp member should be deleted from monster and the save file should be adjusted accordingly (saving the appropriate exp value to the file, for backwards compatibility, but ignoring/skipping...

I believe the unique monster calculation, as currently implemented, is a bug and unique monsters typically also overflowed experience points awarded (JG also mentions this). I think at the start...

Maybe number of players needs to be added to GameData struct? Probably easier to handle that way, if compatible: ```diff struct GameData { int32_t size; /** Used to initialise the...