Charlie Birks

Hmm, think I didn't get to testing it. The patch also had no fallback, so it's a change in supported browsers. (Not sure what we currently support... or should be...

I had [patches](https://github.com/emscripten-ports/SDL2/commits/create-window-from) a while ago to allow specifying the canvas selector using `SDL_CreateWindowFrom` (and use multiple canvases), the problem was that EGL always uses `Module.canvas`... so GL doesn't work....

Newer branch: https://github.com/Daft-Freak/SDL/commits/create-window-from-2 (commits up to adding the hint should be useful here, the rest is WIP multi-window stuff) Has some issues in cursor/framebuffer handling...

Ah nice, skipping the EGL layer also fixes thread/proxying issues. (The cursor issues are that everything else is going through the html5 API/selectors and cursors are still using `Module['canvas'].style ...`)

Note: I haven't tested this after today's rebase. Will try to get that done tomorrow.

Ah, it breaks legacy GL emulation (GL 1.x-ish code). Which is something I've run into before (https://github.com/emscripten-core/emscripten/issues/7871). Hmm...

Yeah, I'm not sure. Losing LEGACY_GL would probably break some (basic) ports... and Emscripten has a bunch of tests for this working. But also, it seems incompatible with the idea...

Hmm, I guess the keysym problem is because we don't get to know what the keyboard layout is... (If this change is okay, I can go delete the workarounds we...

Hmm, this looks relevant: https://github.com/emscripten-core/emscripten/pull/16449 (TBH I was avoiding this hoping that emscripten would handle the js/wasm C magic at some point)

Hmm, I almost opened ~the same PR (but with less duplication): ```diff diff --git a/libraries/pico_graphics/pico_graphics.cmake b/libraries/pico_graphics/pico_graphics.cmake index 67fdd79a..07cc65e5 100644 --- a/libraries/pico_graphics/pico_graphics.cmake +++ b/libraries/pico_graphics/pico_graphics.cmake @@ -1,4 +1,12 @@ -add_library(pico_graphics +if(NOT TARGET...