Gijs van Veen
Gijs van Veen
Iirc, the PhoneVerificationProvider intterface should have a suspend function that returns the verificationId. Implementing the interface allows you to respond. But looking t it now, it probably needs some changes...
We moved some things around and I guess it was just missed we need a constructor to do `DocumentReference(android)`. The reason is this is now wrapped with an internal class...
Good. I have no merging rights though, so my approval is slightly worthless 😂
Your tests were failing for iOS and are still failing for JavaScript (due to test names). Shouldnt CI run these?
The Koin iOS implementation uses the kotlin 'HashMap' on iOS (android uses the Java 'ConcurrentHashMap') . Before that didn't crash, and while it's not great that it does now, this...
fwiw, the problem persists on Kotlin 1.9.21
Wait, isnt it here: https://github.com/GitLiveApp/firebase-kotlin-sdk/tree/master/firebase-crashlytics ?
According to this test it should work https://github.com/GitLiveApp/firebase-kotlin-sdk/blob/2e736d437c19cd27a16da2f208e6338db66e13c8/firebase-firestore/src/commonTest/kotlin/dev/gitlive/firebase/firestore/firestore.kt#L954
@nbransby this is now tracking master, which means the JVM split for firestore is tracked. This PR can now be properly reviewed
Updated tracking again @nbransby