Ismail Özgün Turan
Ismail Özgün Turan
@beberlei / @derrabus does anything speak against merging this?
@ssanchez91 This is not quite complete though. There's another PR also open for this case https://github.com/beberlei/DoctrineExtensions/pull/391 where the implementation includes every functionality of the `JSON_EXTRACT` method.
@ssanchez91 could you clean this up so that it only includes the `JSON_UNQUOTE` instead of also the for this case unnecessary `JSON_EXTRACT`?
If it's currently still unclear why this is happening: https://github.com/symfony/symfony/pull/45476#issuecomment-1163984820
> Is there any pull request to fix that bug? If not, I think it should be fixed before closing, the bug is easily reproducible. Someone probably should check if...
> Thanks for proposing and for submitting! > > I'm wondering if we couldn't get rid of the interface and rename the proposed argument to e.g. `AutowireInline`? To remove the...
> I'm not convinced by the interface, I'd prefer removing it. I'm generally not convinced by interfaces for value objects and attributes are value objects. Extending the class makes sense...
> Please update the PR description to show usages of the feature. This makes it a lot easier for the documentation team (and also for reviewers) Done. Hope that fits...
@nicolas-grekas is there anything left to do here for me :-)? Besides that I wasn't sure about the process: Do I resolve the threads or do you once you check...
> @nicolas-grekas is there anything left to do here for me :-)? > > Besides that I wasn't sure about the process: Do I resolve the threads or do you...