stable-baselines3 icon indicating copy to clipboard operation
stable-baselines3 copied to clipboard

[Feature Request] Make image feature extractor a parameter for CombinedExtractor

Open manuel-delverme opened this issue 3 years ago • 1 comments

🚀 Feature

NatureCNN is hard coded for CombinedExtractor.

https://github.com/DLR-RM/stable-baselines3/blob/master/stable_baselines3/common/torch_layers.py#L258

Motivation

Implementing different networks requires rewriting or patching CombinedExtractor, it's a lot of code.

Pitch

I would be useful to have it as a default rather than hardcoded.

### Checklist

  • [x] I have checked that there is no similar issue in the repo (required)

manuel-delverme avatar Feb 01 '22 15:02 manuel-delverme

Thanks for the suggestion! I fully agree with this and am happy to see you already started a PR :)

Miffyli avatar Feb 01 '22 16:02 Miffyli