stable-baselines3 icon indicating copy to clipboard operation
stable-baselines3 copied to clipboard

Published 20 hours ago • verified publisher icon DLR-RM

Add precommit config yaml and fix typos automatically

Open cschindlbeck opened this issue 1 year ago • 5 comments

Description

Add a pre-commit-config yaml for the pre-commit message, fix its typos accordingly

There are two open points

Motivation and Context

Automatically check codespell in pre-commit hooks, i.e. every time you commit

Checklist

  • [ ] Adapt README.md
  • [ ] Add install/pre-commit install to Makefile?

cschindlbeck avatar Jul 26 '24 14:07 cschindlbeck

Hello, thanks for the PR, but please only keep the typo fixes changes for now.

araffin avatar Jul 29 '24 08:07 araffin

Hello, thanks for the PR, but please only keep the typo fixes changes for now.

I have split the typos from this PR to this https://github.com/DLR-RM/stable-baselines3/pull/1981

However, i would strongly recommend to enforce spellcheck and other checks as proposed in this PR in oder to avoid playing catch-up and get in before such things occur

cschindlbeck avatar Jul 29 '24 08:07 cschindlbeck

Rebased on top of typo fixes

cschindlbeck avatar Jul 29 '24 08:07 cschindlbeck

Anything left to do here @araffin ?

cschindlbeck avatar Feb 01 '25 20:02 cschindlbeck

related: https://github.com/DLR-RM/stable-baselines3/issues/545

araffin avatar Feb 01 '25 21:02 araffin