BlenderProc icon indicating copy to clipboard operation
BlenderProc copied to clipboard

[BUG]: Wrong docstring in simulate_physics_and_fix_final_poses

Open domef opened this issue 2 years ago • 2 comments

Describe the bug The method simulate_physics_and_fix_final_poses has a wrong docstring for the parameter object_stopped_location_threshold (it has the same description has object_stopped_rotation_threshold). The same problem appears in simulate_physics, in _do_simulation and in _have_objects_stopped_moving. All these methods are in blenderproc/python/object/PhysicsSimulation.py.

Now it is:

The maximum difference per second and per coordinate in the rotation Euler vector that is allowed. such that an object is still recognized as 'stopped moving'

It should be something like:

The maximum difference per second and per coordinate in the translation vector that is allowed. Such that an object is still recognized as 'stopped moving'

Also the word such should be capitalized both in object_stopped_location_threshold and in object_stopped_rotation_threshold.

domef avatar Feb 28 '23 13:02 domef

Thanks for letting us know! Would you like to create a PR?

cornerfarmer avatar Mar 01 '23 10:03 cornerfarmer

Yes, I will make it as soon as possible.

domef avatar Mar 01 '23 22:03 domef