Dawid Gracek

Hi, I have the same issue in my projects. If I am not wrong Abaplint knows about parameter type. It could check if it is abap_bool and if it is...

@larshp, it works now for me. Thanks! For future visitors, @larshp added new setting to the no_prefixes rule which is `"allowIsPrefixBoolean": true`.

The same false positive is for mirrored situation: moo = ref->*.

> I was just going to report an issue, then found #2522 Same here 😄 I turned the **_no_inline_in_optional_branches_** on as I was hoping it will somehow work in pair...

> I'll get to it sometime Maybe adding pseudo comment & pragma as the workaround for now would do the trick?

I found a piece in Clean Abap just about comparisons and naming constants meaningful. https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-constants-instead-of-magic-numbers But if you ask me, any hardcode is bad. Where used is very powerful and...

Ok. I see that I am mixing two rules. One is the rule for magic numbers. And I think you are right that sometimes when you call a method number...

@pokrakam, I assumed that abaplint's origin is somehow connected with Clean Abap guide. That's why I opened this issue. Here is the link to the constants section. https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#constants

It is implemented in code_pal for only few cases: https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/magic-number.md

@Pelc314 To be completely honest I don't have any particular solution in mind. The rule already says that > Non-keywords must be lower case. So, probably it is done by...