David von Oheimb comments

Results 316 comments of


David von Oheimb

CRMF: add missing check and API function; clean up `X509{,_REQ}_check_private_key()`

Ping for reviews

CRMF: add missing check and API function; clean up `X509{,_REQ}_check_private_key()`

Asking @openssl/committers for 2nd review.

CRMF: add missing check and API function; clean up `X509{,_REQ}_check_private_key()`

Merged - thanks @t8m and @beldmit

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

Ping @openssl/committers for 2nd approval.

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

Thanks @kaduk for having a closer look and for your further comments. >> We do not need because the error stack entry is already added by the function being called:...

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

For some reason, a couple of CI tests fail when build with `-no-tls1_3`, which I can reproduce locally like this: ``` make test TESTS=test_ssl_new SSL_TESTS=12-ct.cnf ``` but when I try...

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

> > IIRC the test suite has also set a few environment variables at this point, though I would have to look up which ones. > > in `test-runs/test_ssl_new`, running...

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

IMHO it is highly unlikely that anyone who has trouble manually running these SSL tests will notice that there is a file `test/README.ssltest.md` with crucial specific hints. The unexpected implicit...

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

@kaduk I've just returned from vacation and with the help of your above response I've been able to reproduce and fix the remaining CI failure. So your above review comments...

`X509_STORE_CTX_set_default()`: improve error handling and reporting, also in its use

Ping for 2nd review