Artem Medvedev

Results 178 comments of Artem Medvedev

Yes, actually it should work if your runners are properly configured and don't store the state between different jobs. E.g DnD approach will work

@the-wondersmith I will be happy to review the PR. Feel free to open 🙂

Actually I'd like to see how exactly the labels are going to be used, before merging this part. For now it's more like black box without justification (don't get me...

Yeah, thank you for the detailed answer! I understand possible benefits of labels, just wanted to see the whole picture. The labels feature itself is most likely will be merged,...

@the-wondersmith thank you! I'll review as soon as I can. There is no a goal to clean reusable containers, at least for now. Because it's pretty complicated, some users may...

Yes, that totally make sense to implement ENV variable control separately in follow up PR

I'll review the PRs this week, sorry for the delay 🙏

Thanks one more time @the-wondersmith for implementing this feature! 🙏 I think follow-ups were mentioned here: https://github.com/testcontainers/testcontainers-rs/pull/757#pullrequestreview-2504927584 > - env-variable control > - proper reaper for "current session" (ryuk)

I think it's better to create (follow-up/sub)-issues and discuss them separately Because basic implementation has been provided already

Hi @tisonkun 👋 Could you elaborate on this, please? In general, both [WaitFor](https://docs.rs/testcontainers/latest/testcontainers/core/wait/enum.WaitFor.html)(starting from [0.20.0](https://github.com/testcontainers/testcontainers-rs/releases/tag/0.20.0)) and [CmdWaitFor](https://docs.rs/testcontainers/latest/testcontainers/core/enum.CmdWaitFor.html) supports waiting for exit code. Also, `Image` implementation can override [exec_after_start](https://docs.rs/testcontainers/latest/testcontainers/core/trait.Image.html#method.exec_after_start), returning `ExecCommand`s...